> On 27 Sep 2022, at 17:13, Edwin Torok <edvin.to...@citrix.com> wrote: > > > See below for a patch for that. I've included this patch in the correct place > (before the patch that breaks it) in the git repository at: > https://github.com/edwintorok/xen/compare/private/edvint/public0 >
Acked-by: Christian Lindig <christian.lin...@citrix.com> I believe these changes are fine. We are now allocating the event channel dynamically and this requires using a finaliser to free that memory. > -ifneq ($(MAKECMDGOALS),clean) > +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile > $(OCAML_TOPLEVEL)/Makefile.rules > $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli > $o,MLDEP,) > endif Is this the right logic? Moving from ifneq to ifeq here. I am not so familiar with the Makfile rules. The gist seems to be: we depend on auto-generated Make dependencies that the Makefile in general depends on. But in a “make clean” (or other “*clean” it is wasteful to generate these only to later remove them. However, these kind of subtleties are obvious enough while we are working on this but over time accumulate to Makefiles that are hard to change. So I wonder if this kind of optimisation, while correct, is worth it, but fine going along with it. — C
