Hi Jan, > -----Original Message----- > From: Jan Beulich <[email protected]> > Subject: Re: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP > INS/OUTS > > On 10.10.2022 20:08, Andrew Cooper wrote: > > On 06/10/2022 14:11, Jan Beulich wrote: > >> Based on observations on a fair range of hardware from both primary > >> vendors even zero-iteration-count instances of these insns perform the > >> port related permission checking first. > >> > >> Fixes: fe300600464c ("x86: Fix emulation of REP prefix") > >> Signed-off-by: Jan Beulich <[email protected]> > > Reviewed-by: Andrew Cooper <[email protected]>, preferably > with > > some of ^ discussed in the commit message. > > Thanks, I'll apply this provisionally as I'll need to wait for an ack > from Henry anyway.
Sorry I was actually waiting for the review/ack in the Patch#1 of this series so that I can ack them together after they are properly reviewed... > In the meantime you might clarify whether my > responses above (which mean no further discussion in the description > for there being nothing to refer to) don't find your agreement. ...Since IIUC this patch is also trying to harden the code, so as long as you and Andrew reach the agreement of this patch, you can have my: Release-acked-by: Henry Wang <[email protected]> Kind regards, Henry
