Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <[email protected]>
> > (If it will not cause too much time of digging, would you mind adding a
> > "Fixes:" tag pointing to the original commit that missing this
> > ` vcpu_has_nscb()` check when you do the committing? I think this would
> > help to identify this patch as a bugfix so it is more reasonable to commit
> > this patch in current phase. But if too much trouble or you think this is
> > not really a fix then just ignore my comment...)
> 
> There isn't really an appropriate Fixes tag.
> 
> This CPUID bit is one I managed to get AMD to retroactively add to fix
> an enumeration problem they had no anticipated when making a change in
> Zen2.
> 
> i.e. the CPUID bit did not exist at the point at which the code,
> modified in this patch, was written.

Oh, thanks for the clarification! Then please just ignore my comments, sorry
for the noise.

Kind regards,
Henry

> 
> ~Andrew

Reply via email to