This is a good use of the OCaml type system to ensure only compatible flags are shared in a list and not mixed between architectures. The macro changes are good housekeeping.
— C Acked-by: Christian Lindig <[email protected]<mailto:[email protected]>> On 12 Oct 2022, at 19:25, Andrew Cooper <[email protected]<mailto:[email protected]>> wrote: Patch 1 is purely some a tweak to improve legibility. It's not necessary for 4.17 but it's also 0 risk to take as well. Patch 2 is a change to an ABI which was newly introduced in 4.17. It is suboptimal for two reasons and specifically does want changing before 4.17 ships. See patch for details. Andrew Cooper (2): tools/ocaml/xc: Fix code legibility in stub_xc_domain_create() tools/ocaml/xc: Address ABI issues with physinfo arch flags tools/ocaml/libs/xc/xenctrl.ml | 10 ++++++---- tools/ocaml/libs/xc/xenctrl.mli | 11 +++++++---- tools/ocaml/libs/xc/xenctrl_stubs.c | 28 ++++++++++++++-------------- 3 files changed, 27 insertions(+), 22 deletions(-) -- 2.11.0
