Hi Julien, > -----Original Message----- > From: Julien Grall <jul...@xen.org> > Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in > arch_domain_create() > > I think in Arm's arch_domain_create(), all the error handling are the > > same style using: > > > > if ( (rc = <function>) !=0 ) > > goto fail; > > > > and we need to keep them the same? > > We don't have too. I agree with Andrew's point. How about the following: > > spin_lock() > rc = ... > spin_unlock() > > if ( rc ) > goto fail;
Yep this is my current method of local v2. Thanks for the clarification. Working on the p2m_teardown part now... Kind regards, Henry > > Cheers, > > -- > Julien Grall
