On Tue, Oct 11, 2022 at 5:18 AM Jason Andryuk <jandr...@gmail.com> wrote:
> On Fri, Oct 7, 2022 at 9:12 PM Henry Wang <henry.w...@arm.com> wrote: > > > > Hi Andrew and Jason, > > > > > -----Original Message----- > > > From: Andrew Cooper <andrew.coop...@citrix.com> > > > Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE > > > > > > On 07/10/2022 20:31, Jason Andryuk wrote: > > > > I observed this ASSERT_UNREACHABLE in partner_rings_remove > > > consistently > > > > trip. It was in OpenXT with the viptables patch applied. > > > > > > > > dom10 shuts down. > > > > dom7 is REJECTED sending to dom10. > > > > dom7 shuts down and this ASSERT trips for dom10. > > dom7 used a wildcard ring, and dom10 connected to it with a (driver > level) stream socket. > > > > > The argo_send_info has a domid, but there is no refcount taken on > > > > the domain. Therefore it's not appropriate to ASSERT that the domain > > > > can be looked up via domid. Replace with a debug message. > I follow this - thanks for the explanation. > > > > > > > > Signed-off-by: Jason Andryuk <jandr...@gmail.com> > Reviewed-by: Christopher Clark <christopher.w.cl...@gmail.com> > > > > > > We're into the 4.17 release process now. A bugfix like this obviously > > > should be considered, but will need approval from the release manager. > > > CC Henry. > > Thanks, Andrew. > > > Andrew: Thanks for the information! > > > > Jason: Would you mind adding a "Fixes:" tag following the rule described > > in [1]? Thanks very much! With this tag and proper review/ack from > > maintainers: > > Of course. It would be: > Fixes: 82a817307c5b "argo: init, destroy and soft-reset, with enable > command line opt" > > > Release-acked-by: Henry Wang <henry.w...@arm.com> > > Thanks, Henry. We'll see what feedback Christopher provides. > I agree - include for 4.17. thanks Christopher > > Regards, > Jason >
