On Thu, Oct 13, 2022 at 02:05:01PM +0100, Anthony PERARD wrote: > Patch "tools: Add -Werror by default to all tools/" have added > "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > makefiles as it is now duplicated. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > Acked-by: Christian Lindig <christian.lin...@citrix.com> > Acked-by: Daniel P. Smith <dpsm...@apertussolutions.com> # tools/flask > Acked-by: Jan Beulich <jbeul...@suse.com> # tools/*/cpu-policy > --- > > Notes: > missing-ack: > - GDBSX DEBUGGER > - KDD DEBUGGER > - XENTRACE > > tools/console/client/Makefile | 1 - > tools/console/daemon/Makefile | 1 - > tools/debugger/kdd/Makefile | 1 - > tools/flask/utils/Makefile | 1 - > tools/fuzz/cpu-policy/Makefile | 2 +- > tools/misc/Makefile | 1 - > tools/tests/cpu-policy/Makefile | 2 +- > tools/tests/depriv/Makefile | 2 +- > tools/tests/resource/Makefile | 1 - > tools/tests/tsx/Makefile | 1 - > tools/tests/xenstore/Makefile | 1 - > tools/xcutils/Makefile | 2 -- > tools/xenmon/Makefile | 1 - > tools/xenpaging/Makefile | 1 - > tools/xenpmd/Makefile | 1 - > tools/xentop/Makefile | 2 +- > tools/xentrace/Makefile | 2 -- > tools/xl/Makefile | 2 +- > tools/debugger/gdbsx/Rules.mk | 2 +- > tools/firmware/Rules.mk | 2 -- > tools/libfsimage/common.mk | 2 +- > tools/libs/libs.mk | 2 +- > tools/ocaml/common.make | 2 +- > tools/xenstore/Makefile.common | 1 - > 24 files changed, 9 insertions(+), 27 deletions(-)
Missing hunk as pointed out by Andrew: diff --git a/tools/pygrub/setup.py b/tools/pygrub/setup.py index b8f1dc4590..0e4e3d02d3 100644 --- a/tools/pygrub/setup.py +++ b/tools/pygrub/setup.py @@ -3,7 +3,7 @@ from distutils.ccompiler import new_compiler import os import sys -extra_compile_args = [ "-fno-strict-aliasing", "-Werror" ] +extra_compile_args = [ "-fno-strict-aliasing" ] XEN_ROOT = "../.." diff --git a/tools/python/setup.py b/tools/python/setup.py index 8c95db7769..721a3141d7 100644 --- a/tools/python/setup.py +++ b/tools/python/setup.py @@ -8,7 +8,7 @@ SHLIB_libxenctrl = os.environ['SHLIB_libxenctrl'].split() SHLIB_libxenguest = os.environ['SHLIB_libxenguest'].split() SHLIB_libxenstore = os.environ['SHLIB_libxenstore'].split() -extra_compile_args = [ "-fno-strict-aliasing", "-Werror" ] +extra_compile_args = [ "-fno-strict-aliasing" ] PATH_XEN = XEN_ROOT + "/tools/include" PATH_LIBXENTOOLLOG = XEN_ROOT + "/tools/libs/toollog" We can see the change, or duplicate of "-Werror" in commands run by setup.py by running `setup.py build --verbose`. -- Anthony PERARD
