Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > > I added the doc asked in your previous email. Also, I will use a > > > > ASSERT(p2m_teardown(d, false) == 0); > > > > in p2m_final_teardown() here. > > Hopefully this was meant only as an abstract plan, not the exact code > you mean to add? ASSERT() expressions generally should not have side > effects (which includes function calls).
Yeah, when I wrote the v3 code I noticed that ASSERT might be limited to the CONFIG_DEBUG so in the v3 I switched to BUG_ON which IIUC can make sure the function call is valid all the time. Kind regards, Henry > > Jan