Thanks Paul & Julien for reviewing. I will update this in v2. Regards, Vikram
From: Paul Durrant <[email protected]> Date: Wednesday, October 19, 2022 at 9:16 AM To: Garhwal, Vikram <[email protected]>, [email protected] <[email protected]> Cc: Stabellini, Stefano <[email protected]>, Stefano Stabellini <[email protected]>, Anthony Perard <[email protected]>, Michael S. Tsirkin <[email protected]>, Marcel Apfelbaum <[email protected]>, Paolo Bonzini <[email protected]>, Richard Henderson <[email protected]>, Eduardo Habkost <[email protected]>, open list:X86 Xen CPUs <[email protected]> Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c On 15/10/2022 06:07, Vikram Garhwal wrote: [snip] > + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); > + > + state->memory_listener = xen_memory_listener; > + memory_listener_register(&state->memory_listener, &address_space_memory); > + > + state->io_listener = xen_io_listener; > + memory_listener_register(&state->io_listener, &address_space_io); > + > + state->device_listener = xen_device_listener; > + QLIST_INIT(&state->dev_list); > + device_listener_register(&state->device_listener); > + As Julien said, these do not belong here. These are the (current and legacy) PV backend setup functions; they most certainly have nothing to do with device emulation. Paul
