Hi Jiamei,
On 20/10/2022 05:00, Jiamei Xie wrote:
>
>
> Hi Michal,
>
>> -----Original Message-----
>> From: Xen-devel <[email protected]> On Behalf Of
>> Michal Orzel
>> Sent: Tuesday, September 27, 2022 5:47 PM
>> To: [email protected]
>> Cc: Michal Orzel <[email protected]>; Doug Goldstein
>> <[email protected]>; Stefano Stabellini <[email protected]>
>> Subject: [PATCH v3 05/10] automation: Add Arm containers to containerize
>> script
>>
>> Script automation/scripts/containerize makes it easy to build Xen within
>> predefined containers from gitlab container registry. This script is
>> currently missing the helpers to select Arm containers, so populate the
>> necessary entries.
>>
>> Signed-off-by: Michal Orzel <[email protected]>
>> Acked-by: Stefano Stabellini <[email protected]>
>> ---
>
> [Jiamei Xie]
> I wonder if an default container for arm can be added. For example, if
> "CONTAINER=arm64 automation/scripts/containerize bash",
> set the default CONTAINER as
> "registry.gitlab.com/xen-project/xen/alpine:3.12-arm64v8"
>
It can be added doing the following:
diff --git a/automation/scripts/containerize b/automation/scripts/containerize
index 0f4645c4cccb..b395bd359ecf 100755
--- a/automation/scripts/containerize
+++ b/automation/scripts/containerize
@@ -25,7 +25,7 @@ die() {
BASE="registry.gitlab.com/xen-project/xen"
case "_${CONTAINER}" in
_alpine) CONTAINER="${BASE}/alpine:3.12" ;;
- _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
+ _alpine-arm64v8|_arm64) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
_archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;;
_riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;;
_centos7) CONTAINER="${BASE}/centos:7" ;;
The question is whether it would be beneficial. After all you would still need
to
type CONTAINER=arm64, whereas at the moment, you need to type
CONTAINER=alpine-arm64v8.
TBH I'm not sure it is improving anything (?).
~Michal
