Hi Andrew,
On 21/10/2022 15:31, Andrew Cooper wrote:
>
>
> On 21/10/2022 14:22, Michal Orzel wrote:
>> All the build jobs exist in two flavors: debug and non-debug, where the
>> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
>> is only being recognized by the toolstack, because Xen requires
>> enabling/disabling debug build via e.g. menuconfig/config file.
>> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
>> set to a default value ('y' for unstable and 'n' for stable branches),
>> regardless of the type of the build job.
>>
>> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
>>
>> Signed-off-by: Michal Orzel <michal.or...@amd.com>
>> ---
>> Xen used debug variable to control the build type before switching to
>> Kconfig.
>> Support for GitLab CI was added later, which means that this issue was always
>> present. This is a low risk for 4.17 with a benefit of being able to test Xen
>> in both debug and non-debug versions.
>
> Both series were floating around for ages before being accepted. It's
> quite possible that one bitrotted around the other.
>
> This should be backported, and therefore should be considered for 4.17
> at this point.
>
> Is there a Gitlab CI run which includes this patch?
I submitted the one here not long ago:
https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/673396949
and there is already one failure in Arm boot-cpupools test because the script
sets null
scheduler for the domain which is not present in non-debug build...
>
> ~Andrew
~Michal
