> On 26 Oct 2022, at 13:06, Jan Beulich <jbeul...@suse.com> wrote: > > On 25.10.2022 12:13, Luca Fancellu wrote: >> Here is an example to add a new justification in safe.json:: >> >> |{ >> | "version": "1.0", >> | "content": [ >> | { >> | "id":"SAF-0-safe", >> | "analyser": { >> | "cppcheck": "misra-c2012-20.7", >> | "coverity": "misra_c_2012_rule_20_7_violation", >> | "eclair": "MC3R1.R20.7" >> | }, >> | "name": “R20.7 C macro parameters not used as expression", >> | "text": "The macro parameters used in this […]" >> | }, >> | { >> | "id":”SAF-1-safe", >> | "analyser": { >> | "cppcheck": "unreadVariable", >> | "coverity": "UNUSED_VALUE" >> | }, >> | "name": “Variable set but not used", >> | "text": “It is safe because […]" >> | }, >> | { >> | "id":”SAF-2-safe", >> | "analyser": {}, >> | "name": "Sentinel", >> | "text": "" >> | } >> | ] >> |} > > Besides the still inconsistent use of double quote forms (as also pointed > out by Stefano) I'd further like to point out that colons still aren't > uniformly followed by a blank (both pointed out at v1 already, and iirc > you agreed to make both aspects consistent).
Yes, thank you for your review on v1 and here, I’ve already fixed them in my patches, I forgot to do that sending the v2, the final document will have a consistent style. Cheers, Luca > > Jan