On 07.11.22 16:09, Jan Beulich wrote:
This reverts a small part of 7e21b25059ed ("xen: harmonize return types of hypercall handlers"). The change from "unsigned long" to "unsigned int" for the native handler function meant that previously invalid values became valid. While perhaps not a significant issue, strictly speaking that's still a change to the ABI. Don't go as far as restoring the compat entry point's type though: That one can't have values passed which don't fit in 32 bits.Note that as a side effect this fixes the invocation of hypercall_create_continuation(), which by mistake wasn't adjusted by the earlier change. Also take the opportunity and correct the respective comment in the public header. (The way it was it really supports that it probably was pointless to use "long", but that's the way the hypercall was introduced.) Requested-by: Andrew Cooper <[email protected]> Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Juergen Gross <[email protected]> Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
