On 09.11.2022 12:36, Roger Pau Monné wrote:
> Since I don't see replies to my other comments, do you agree on
> returning an error then?
No, my view there hasn't changed. I wouldn't block a change to go in
early for 4.18, but I also wouldn't ack such.
Perhaps just one remark on your other earlier comments: While you're
right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random
data in the bitmap may cause a caller to do extra work, but wouldn't
look to be otherwise harmful: Considering pages dirty which aren't
is never a functional problem, while considering pages clean which
aren't is (imo) not a problem for a dying domain.
Jan
