Hi Luca, > On 9 Nov 2022, at 14:04, Luca Fancellu <[email protected]> wrote: > > The commit 3c2a14ea81c7 is introducing some unsupported arm features > that by default are disabled and are used for the cpufeature.c code. > > As they are disabled by default, a typo in the Kconfig symbol they > depend on has landed in the codebase unnoticed, instead of depending > on ARM64 which does not exist, fix the code to depend on ARM_64 that > is the intended symbol. > > Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 cpufeatures") > Signed-off-by: Luca Fancellu <[email protected]>
Reviewed-by: Bertrand Marquis <[email protected]> I think this should go in 4.17 as it is fixing an invalid depends in Kconfig. The change cannot create any issue as those config options are hidden and default to n at the moment. Cheers Bertrand > --- > xen/arch/arm/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847b8..52a05f704da5 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -105,28 +105,28 @@ config HARDEN_BRANCH_PREDICTOR > > config ARM64_PTR_AUTH > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Pointer authentication support. > This feature is not supported in Xen. > > config ARM64_SVE > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Scalar Vector Extension support. > This feature is not supported in Xen. > > config ARM64_MTE > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Memory Tagging Extension support. > This feature is not supported in Xen. > > config ARM64_BTI > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Branch Target Identification support. > This feature is not supported in Xen. > -- > 2.17.1 >
