Hi, On 23/11/2022 16:22, Bertrand Marquis wrote:
On 23 Nov 2022, at 14:39, Michal Orzel <[email protected]> wrote:When creating direct mapped domU, the vIRQ for vpl011 is taken from the SERHND_DTUART serial port using serial_irq. This function can return -1 (i.e. no interrupt found) in which case we should call a panic. However, vpl011_virq is defined as unsigned int which causes the panic to be unreachable, because less than zero comparison of an unsigned value can never be true. Fix it by defining vpl011_virq as int. Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") Signed-off-by: Michal Orzel <[email protected]>Reviewed-by: Bertrand Marquis <[email protected]>
I have committed it in a branch for-next/4.18 which will be merged once the tree reopened.
Cheers, -- Julien Grall
