On 29/11/2022 14:51, Jan Beulich wrote:
> Up until f61685a66903 ("x86: remove defunct init/load/save_msr()
> hvm_funcs") the check of the _rsvd field served as an error check for
> the earlier hvm_funcs.save_msr() invocation. With that invocation gone
> the check makes no sense anymore. While dropping it also merge the two
> paths setting "err" to -ENXIO.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
> ---
> We could go further here, removing the local "err" variable altogether,
> by using "return -ENXIO". Thoughts.'err' is a non-standard variable name, so yeah, why not. That said, the current code has a split loop checking the incoming _rsvd fields in a first pass, and then calling guest_wrmsr() on the second pass. This was also made pointless by the identified changeset, so the two loops ought to be merged. ~Andrew
