Hi Jan, > On 2 Dec 2022, at 8:45 am, Jan Beulich <[email protected]> wrote: > > On 01.12.2022 17:02, Rahul Singh wrote: >> Add new viommu_type field and field values XEN_DOMCTL_CONFIG_VIOMMU_NONE >> XEN_DOMCTL_CONFIG_VIOMMU_SMMUV3 in xen_arch_domainconfig to >> enable/disable vIOMMU support for domains. >> >> Also add viommu="N" parameter to xl domain configuration to enable the >> vIOMMU for the domains. Currently, only the "smmuv3" type is supported >> for ARM. >> >> Signed-off-by: Rahul Singh <[email protected]> >> --- >> docs/man/xl.cfg.5.pod.in | 11 +++++++++++ >> tools/golang/xenlight/helpers.gen.go | 2 ++ >> tools/golang/xenlight/types.gen.go | 1 + >> tools/include/libxl.h | 5 +++++ >> tools/libs/light/libxl_arm.c | 13 +++++++++++++ >> tools/libs/light/libxl_types.idl | 6 ++++++ >> tools/xl/xl_parse.c | 9 +++++++++ >> 7 files changed, 47 insertions(+) > > This diffstat taken together with the title makes me assume that e.g. ... > >> --- a/tools/libs/light/libxl_arm.c >> +++ b/tools/libs/light/libxl_arm.c >> @@ -179,6 +179,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, >> return ERROR_FAIL; >> } >> >> + switch (d_config->b_info.arch_arm.viommu_type) { >> + case LIBXL_VIOMMU_TYPE_NONE: >> + config->arch.viommu_type = XEN_DOMCTL_CONFIG_VIOMMU_NONE; > > ... this constant doesn't exist yet, and hence this would fail to build > at this point in the series. I notice, however, that the constants are > introduced in earlier patches. Perhaps the title here wants re-wording?
Yes, I will fix the commit msg. Regards, Rahul
