> On 5 Dec 2022, at 15:58, Jan Beulich <[email protected]> wrote: > > On 05.12.2022 16:40, Luca Fancellu wrote: >> The script xen-analysis.py is going to be used for the analysis with >> cppcheck, so remove the rules from the Makefile >> >> The python script xen/tools/merge_cppcheck_reports.py was used by the >> makefile rules, but its functionality is integrated in the >> xen-analysis.py script now, so it can be removed. >> >> Remove some entry from the .gitignore related to Cppcheck invocation >> from Makefile >> >> Signed-off-by: Luca Fancellu <[email protected]>
Hi Jan, > > Is this a proper revert of one or more earlier patches? If so, you want > to say so, for being potentially relevant for (at least) review purposes. > If not, it would also help saying so to clarify what is being kept. It is a partial revert of commits 57caa53753212 and 43aa3f6e72d34, I’ve reverted only the Makefile changes, the xen/tools/merge_cppcheck_reports.py script and some entries in .gitignore. Should I put this in the commit message? > > Jan
