Hi,
On 07/10/2022 11:32, Mykyta Poturai wrote:
From: Mirela Simonovic <[email protected]>
Freeze and thaw of domains is reused as implemented for x86. In
addition, system_state variable is updated to represent the actual
state of the system.
Signed-off-by: Mirela Simonovic <[email protected]>
Signed-off-by: Saeed Nowshadi <[email protected]>
Your signed-off-by is missing.
---
xen/arch/arm/suspend.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index b09bf319d0..2b94816b63 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -137,6 +137,14 @@ static long system_suspend(void *data)
So this is something I already hinted in the original series. But I will
repeat here.
I find quite difficult to review the code in system_suspend() when this
introduced in piece meal. For instance, patch #8 is fixing a bug
introduced by patch #7.
Patch #7 adds barrier after code your added here...
So I would much prefer if we introduce the helpers in a few patches and
then have one patch that will in system_suspend().
Cheers,
--
Julien Grall
