On 08.12.2022 00:24, Stefano Stabellini wrote:
> Fix several MISRA Issues Rule 8.4 ("A compatible declaration shall be
> visible when an object or function with external linkage is defined")
> found by cppcheck affecting xen/xsm/flask.
>
> - policydb_loaded_version is not declared; removed it because it is
> unused
> - move ss_initialized declaration to xen/xsm/flask/include/conditional.h
> - #include <conditional.h> (which is
> xen/xsm/flask/include/conditional.h) in xen/xsm/flask/ss/policydb.c so
> that policydb.c also gets the declaration of ss_initialized
> - #include <conditional.h> in xen/xsm/flask/ss/services.c to declare
> security_*_bools functions that services.c is defining and using
>
> This patch solves all the Rule 8.4 violations found by cppcheck on xsm/
>
> Signed-off-by: Stefano Stabellini <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>
But I'll continue the v1 thread wrt the two conditional.h; that's
independent of the changes done here, though.
Jan
