On Tue, Dec 06, 2022 at 10:18:14PM -0800, Vikram Garhwal wrote: > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 2321a648a5..82fc7ce6b9 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -245,6 +245,11 @@ > */ > #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1 > > +/** > + * This means Device Tree Overlay is supported. > + */ > +#define LIBXL_HAVE_DT_OVERLAY 1 > + > /* > * libxl_domain_build_info has device_model_user to specify the user to > * run the device model with. See docs/misc/qemu-deprivilege.txt. > @@ -2448,6 +2453,9 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, > uint32_t domid, > int *num); > void libxl_device_pci_list_free(libxl_device_pci* list, int num); > > +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay, > + uint32_t overlay_size, uint8_t overlay_op); > +
Could you guard both the LIBXL_HAVE_* macro and this prototype with "#if arm"? Since the dt_overlay operation to libxl built on arm. > /* > * Turns the current process into a backend device service daemon > * for a driver domain. > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile > index 374be1cfab..2fde58246e 100644 > --- a/tools/libs/light/Makefile > +++ b/tools/libs/light/Makefile > @@ -111,6 +111,9 @@ OBJS-y += _libxl_types.o > OBJS-y += libxl_flask.o > OBJS-y += _libxl_types_internal.o > > +# Device tree overlay is enabled only for ARM architecture. > +OBJS-$(CONFIG_ARM) += libxl_dt_overlay.o > + > ifeq ($(CONFIG_LIBNL),y) > CFLAGS_LIBXL += $(LIBNL3_CFLAGS) > endif > diff --git a/tools/libs/light/libxl_dt_overlay.c > b/tools/libs/light/libxl_dt_overlay.c > new file mode 100644 > index 0000000000..38cab880a0 > --- /dev/null > +++ b/tools/libs/light/libxl_dt_overlay.c > +#include "libxl_osdeps.h" /* must come before any other headers */ > +#include "libxl_internal.h" > +#include <libfdt.h> > +#include <xenguest.h> > +#include <xenctrl.h> Don't you need just xenctrl.h and not xenguest.h? (They both already are libxl_internal.h so I'm not sure if xenguest.h is needed., but xc_dt_overlay() is in xenctrl.h) Thanks, -- Anthony PERARD
