Sorry for late reply... On Mon, Dec 05, 2022 at 04:10:28PM +0100, Jan Beulich wrote: > On 23.11.2022 16:45, Roger Pau Monne wrote: > > Only set the GOP mode if vga is selected in the console option, > > otherwise just fetch the information from the current mode in order to > > make it available to dom0. > > > > Introduce support for passing the command line to the efi_multiboot2() > > helper, and parse the console= option if present. > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > --- > > I'm unsure why the parsing of the multiboot2 tags is done in assembly, > > it could very well be done in efi_multiboot2() in C, but I don't want > > to switch that code now. > > I guess that's mainly mirroring the non-EFI boot path, where the amount > of work needed to eventually enter C land is quite a bit larger? > Anything beyond that Daniel may want to point out.
Yeah, you are right, its mainly mirroring the non-EFI boot path and it evolved from that code. However, if you want to move it to C go for it... Daniel
