On 13.12.2022 17:31, Roger Pau Monne wrote:
> --- a/xen/arch/x86/include/asm/perfc_defn.h
> +++ b/xen/arch/x86/include/asm/perfc_defn.h
> @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions,           "exceptions", 32)
>  
>  #ifdef CONFIG_HVM
>  
> -#define VMX_PERF_EXIT_REASON_SIZE 65
> +#define VMX_PERF_EXIT_REASON_SIZE 75
>  #define VMEXIT_NPF_PERFC 143
>  #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1)
>  PERFCOUNTER_ARRAY(vmexits,              "vmexits",
> @@ -128,4 +128,6 @@ PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop 
> Detection")
>  PERFCOUNTER(iommu_pt_shatters,    "IOMMU page table shatters")
>  PERFCOUNTER(iommu_pt_coalesces,   "IOMMU page table coalesces")
>  
> +PERFCOUNTER(buslock, "Bus Locks Detected")
> +
>  /*#endif*/ /* __XEN_PERFC_DEFN_H__ */

Is there a particular reason this is added outside the / another CONFIG_HVM
conditional? (I realize the one we have only covers part of what's HVM-
specific, but it would be nice if new ones were constrained right away
(unless there's a clear expectation for them to be re-used in a more general
fashion).

Jan

Reply via email to