Re: [RFC PATCH 1/3] xen/spinlock: add explicit non-recursive locking functions

[Juergen Gross]

On 14.12.22 11:21, Jan Beulich wrote:

On 10.09.2022 17:49, Juergen Gross wrote:

In order to prepare a type-safe recursive spinlock structure, add
explicitly non-recursive locking functions to be used for non-recursive
locking of spinlocks, which are use recursively, too.

While I can see that something needs doing, a function name like
spin_unlock_nonrecursive_irqrestore() is really unwieldy, imo.

Would you be fine with s/nonrecursive/nonrec/ in all the names?

Just one minor further remark:

@@ -64,7 +64,7 @@ void pcidevs_unlock(void)

  {
-    return !!spin_is_locked(&_pcidevs_lock);
+    return !!spin_recursive_is_locked(&_pcidevs_lock);
  }

bool_t pcidevs_locked(void)

While touching this line, could you please also get rid of the !! ?

Okay.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature