On Fri, Dec 16, 2022 at 06:25:15PM +0000, Edwin Török wrote: > Add a .clang-format configuration that tries to match CODING_STYLE where > possible.
Is there going to be a patch applying this to "tools/ocaml", like you did with "make format"? > I was not able to express the special casing of braces after 'do' > though, this can only be controlled generally for all control > statements. > It is imperfect, but should be better than the existing bindings, which > do not follow Xen coding style. There isn't a single CODING_STYLE for all code in the repo so it isn't an issue if the binding where having a different coding style. But having as few coding style as possible in the repo is probably helpful. You could maybe add a CODING_STYLE in "tools/ocaml" to say that the coding style is running `make format` or `clang-format ...`. And if there other rules like how to name certain variable, that could go in this file as well. Cheers, -- Anthony PERARD
