On 16.12.2022 12:48, Julien Grall wrote: > From: Hongyan Xia <[email protected]> > > This avoids the assumption that boot pages are in the direct map. > > Signed-off-by: Hongyan Xia <[email protected]> > Signed-off-by: Julien Grall <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> However, ... > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit > *slit) > return; > } > mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); > - acpi_slit = mfn_to_virt(mfn_x(mfn)); > + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length)); ... with the increased use of vmap space the VA range used will need growing. And that's perhaps better done ahead of time than late. > + BUG_ON(!acpi_slit); Similarly relevant for the earlier patch: It would be nice if boot failure for optional things like NUMA data could be avoided. But I understand this is somewhat orthogonal to this series (the more that alloc_boot_pages() itself is also affected). Yet not entirely so, since previously there was no mapping failure possible here. Jan
