On 20/12/2022 3:18 pm, Jan Beulich wrote: > On 20.12.2022 15:50, Andrew Cooper wrote: >> On 19/12/2022 2:45 pm, Sergey Dyasli wrote: >>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >>> index 6bb5bc7c84..2d7c815e0a 100644 >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> relocated = true; >>> @@ -1762,11 +1768,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) >>> >>> init_IRQ(); >>> >>> - microcode_grab_module(module_map, mbi); >>> - >>> timer_init(); >>> >>> - early_microcode_init(); >>> + early_microcode_init_cache(module_map, mbi); >> microcode_init_cache(module_map, mbi); /* Needs xmalloc() */ >> >> Can fix on commit. > Are you merely after the added comment, or is the omission of the early_ > prefix also meaningful in some way?
This isn't "early_microcode" and frankly wasn't "early" to begin with. Caching the blob can happen at any time after the heap is set up, so should not have anything like "early" in its name. The comment is just to make it easier in the future to figure out how to rearrange __start_xen(). ~Andrew
