On Thu, 12 Jan 2023 23:14:26 -0500 Chuck Zmudzinski <brchu...@aol.com> wrote:
> On 1/12/23 6:03 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 12, 2023 at 10:55:25PM +0000, Bernhard Beschow wrote: > >> I think the change Michael suggests is very minimalistic: Move the if > >> condition around xen_igd_reserve_slot() into the function itself and > >> always call it there unconditionally -- basically turning three lines > >> into one. Since xen_igd_reserve_slot() seems very problem specific, > >> Michael further suggests to rename it to something more general. All > >> in all no big changes required. > > > > yes, exactly. > > > > OK, got it. I can do that along with the other suggestions. have you considered instead of reservation, putting a slot check in device model and if it's intel igd being passed through, fail at realize time if it can't take required slot (with a error directing user to fix command line)? That could be less complicated than dealing with slot reservations at the cost of being less convenient. > > Thanks. >
