Hi Michal, > -----Original Message----- > Subject: RE: [PATCH] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation > > >> -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) > > >> +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (266 - 256)) > > > > > > From the commit message "L0 slots from 256 to 265 (i.e. 10 slots)", I > > > think > > > the actual range is [256, 265] so probably using "(265 - 256 + 1)" here > > > is a > > > bit better? It seems to me that the number 266 looks like a magic number > > > because 266 is not in the range. But this is my personal taste though and > > > I > > > am open to discussion if you or maintainers have other opinions. > > > > I think this is a matter of taste. > > Yes indeed, so I wouldn't argue for your explanation...
Sorry I mean argue against here... :) Kind regards, Henry
