On 18/01/2023 8:06 am, Jan Beulich wrote: > On 17.01.2023 18:21, Andrew Cooper wrote: >> On 16/01/2023 6:10 pm, Anthony PERARD wrote: >>> + elif re.match(r'^[a-zA-Z_]', token): >> [...] >> >> All of this said, where is 0-9 in the token regex? Have we just got >> extremely lucky with having no embedded digits in identifiers thus far? > That's checking for just the first character, which can't be a digit?
So it is... But nothing good can possibly come of having a token here which matches on the first char but mismatches later. > >> P.S. I probably don't want to know why we have to special case evtchn >> port, argo port and domain handle. I think it says more about the this >> bodge of a parser than anything else... > Iirc something broke without it, but it's been too long and spending a > reasonable amount of time trying to re-construct I couldn't come up > with anything. I didn't want to go as far as put time into actually > trying out what (if anything) breaks with those removed. What I'm > puzzled about is that argo and evtchn port types are handled in > different places. > > For the domain handle iirc the exception was attributed to it being > the only typedef of an array which is embedded in other structures. I refer back to "bodge of a parser". ~Andrew
