On 23/01/2023 8:12 am, Jan Beulich wrote:
> While the table is used only when HVM=y, the table entry of course needs
> to be properly populated when also PV32=y. Fully removing the table
> entry we therefore wrong.
>
> Fixes: 1894049fa283 ("x86/shadow: L2H shadow type is PV32-only")
> Signed-off-by: Jan Beulich <[email protected]>Erm, why? The safety justification for the original patch was that this is HVM only code. And it really is HVM only code - it's genuinely compiled out for !HVM builds. So if putting this entry back in fixes the regression OSSTest identified, then either SH_type_l2h_64_shadow isn't PV32-only, or we have PV guests entering HVM-only logic. Either way, the precondition for correctness of the original patch is violated, and it needs reverting on those grounds alone. ~Andrew
