Hi Michal and Julien, Apologies for the late response.
> -----Original Message----- > >> + PROGRESS(p2m_root): > >> + /* > >> + * We are about to free the intermediate page-tables, so clear the > >> + * root to prevent any walk to use them. > > The comment from here... > >> + * The domain will not be scheduled anymore, so in theory we > should > >> + * not need to flush the TLBs. Do it for safety purpose. > >> + * Note that all the devices have already been de-assigned. So we > don't > >> + * need to flush the IOMMU TLB here. > >> + */ > > to here does not make a lot of sense in this place and should be moved to > p2m_clear_root_pages > > where a user can see the call to p2m_force_tlb_flush_sync. > > +1 I will move this code comment block to the place that you suggested in v2. > > > Apart from that: > > Reviewed-by: Michal Orzel <[email protected]> > > Acked-by: Julien Grall <[email protected]> Thanks to both of you. I will keep these two tags with the fix about the above in-code comment position. Kind regards, Henry > > Cheers, > > -- > Julien Grall
