On 02/05/2018, 12:45, "Ian Jackson" <[email protected]> wrote:
Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl
script to optimise the workflow when using git format-patch with
get_maintainer.pl"):
> On 02/05/2018, 11:50, "Ian Jackson" <[email protected]> wrote:
> If the address is a mailing list for some other stanza in MAINTAINERS,
> ie for a stanza whose files are not touched by this patch, then it
> should still be treated as a list.
>
> So what I meant was that you should search the whole of MAINTAINERS
> yourself for all the L: lines, regardless of where they appear.
>
> But that is exactly what get_maintainers.pl --nom --nor does
mariner:xen.git> scripts/get_maintainer.pl --nom --nor
scripts/get_maintainer.pl: missing patchfile or -f file - use --help if
necessary
It requires a patch. But for this purpose, we don't want any patch.
> That avoids calling get_maintainer.pl twice too, so helpfully the
> other difficulties you discuss go away.
>
> I suppose it does. But it also makes the script re-implement bits
> of get_maintainers.pl
Finding lines starting with L: is so simple that I wouldn't bother
calling get_maintainer.pl for it.
OK. I will do that then.
> > We could make this configurable:
> > Default: all tags, except signed-off-by (unless of course this
should be added to the CC)
>
> Why not CC the S-o-b ? Usually that will be the author anyway.
>
> I wasn't sure.
>
> Particularly if you used -i ccbody, which we agreed in another mail should
> be the default, you then will end up with
> CC: [email protected]
> ...
> Signed-off-by: [email protected]
>
> Which would annoy me personally.
Ideally no-one should be mentioned in the CC that is mentioned in some
other tag.
CC: [email protected]
Tested-by: [email protected]
is just as silly.
That tells me that that entire --tags infrastructure should only be used
when inserting into the header and ignored otherwise. This makes
everything simpler. No need to include extra options, etc.
If --tags is there, then
a) Retrieve any tags via the *-by: regex
b) Only insert at the top of the mail
Then there is really no reason why to do anything more complex.
Regards
Lars
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
