On 07.02.2023 15:46, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/csr.h > @@ -0,0 +1,84 @@ > +/* > + * SPDX-License-Identifier: GPL-2.0-only > + * > + * Copyright (C) 2015 Regents of the University of California > + */ > + > +#ifndef _ASM_RISCV_CSR_H > +#define _ASM_RISCV_CSR_H > + > +#include <asm/asm.h> > +#include <xen/const.h> > +#include <asm/riscv_encoding.h> > + > +#ifndef __ASSEMBLY__ > + > +#define csr_read(csr) \ > +({ \ > + register unsigned long __v; \ > + __asm__ __volatile__ ( "csrr %0, " __ASM_STR(csr) \
Nit: There's now one too many space (here and elsewhere below) between the opening parenthesis and the opening double quote. > +#define csr_clear(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrc " __ASM_STR(csr) ", %0" \ > + : /*no outputs */ \ Nit: Missing blank inside comment. I think these adjustments could be done while committing, assuming no other changes are necessary and an ack appears. Jan