Re: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system

[Julien Grall]

Hi,

On 13/01/2023 10:10, Jan Beulich wrote:

On 13.01.2023 06:29, Penny Zheng wrote:

--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -13,9 +13,10 @@ config ARM
        def_bool y
        select HAS_ALTERNATIVE if !ARM_V8R
        select HAS_DEVICE_TREE
+       select HAS_FIXMAP if !ARM_V8R
        select HAS_PASSTHROUGH
        select HAS_PDX
-       select HAS_PMAP
+       select HAS_PMAP if !ARM_V8R
        select IOMMU_FORCE_PT_SHARE
        select HAS_VMAP if !ARM_V8R

Thinking about it - wouldn't it make sense to fold HAS_VMAP and HAS_FIXMAP
into a single HAS_MMU?

I think it would make sense.

Furthermore, this patch would be better towards the start of the series.

Cheers,

--
Julien Grall