On 09.02.2023 13:35, Oleksii wrote:
> On Wed, 2023-02-08 at 15:01 +0100, Jan Beulich wrote:
>> On 08.02.2023 13:00, Oleksii wrote:
>>> On Tue, 2023-02-07 at 16:07 +0100, Jan Beulich wrote:
>>>> On 07.02.2023 15:46, Oleksii Kurochko wrote:
>>>>> + switch ( id )
>>>>> + {
>>>>> + case BUGFRAME_warn:
>>>>> + /*
>>>>> + * TODO: change early_printk's function to
>>>>> early_printk
>>>>> with format
>>>>> + * when s(n)printf() will be added.
>>>>> + */
>>>>> + early_printk("Xen WARN at ");
>>>>> + early_printk(filename);
>>>>> + early_printk(":");
>>>>> + // early_printk_hnum(lineno);
>>>>
>>>> What's this? At the very least the comment is malformed.
>>> It's an old code that should be removed.
>>
>> Removed? I.e. the line number will never be logged?
> It will, but:
> 1. I decided not to provide early_printk_hnum() and focus on getting
> printk() working.
> 2. I introduced generic do_bug_frame() [1] (at least, for ARM and RISC-
> V) so the current implementation will be switched to generic one when
> panic, printk and find_text_region() (virtual memory) will be
> ready/merged. It is what I am going to do next.
If that's to tell me that the code above to going to be replaced soon,
then a well-formed commented-out piece of code is probably best for now.
Jan
> [2] - is a link to patch series with introduction of generic
> implementation of macros from bug.h. Probably you can look at it too
> when you will have free time. Thank you so much for your attention and
> participation.
>
> [1]
> https://lore.kernel.org/xen-devel/8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kuroc...@gmail.com/
> [2]
> https://lore.kernel.org/xen-devel/?q=%22introduce+generic+implementation+of+macros+from+bug.h%22
>>
>> Jan
>
> ~ Oleksii
>
