On 2/23/23 12:29, Jan Beulich wrote:
On 22.02.2023 13:00, Xenia Ragiadakou wrote:
Do not include the headers:
asm/i387.h
asm/hvm/trace.h
asm/processor.h
asm/regs.h
because none of the declarations and macro definitions in them is used in
this file. Sort the rest of the headers alphabetically.
Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy().
Nit: You don't really "fix" the build, you keep it working.
Ok I will rephrase it in v3.
Signed-off-by: Xenia Ragiadakou <[email protected]>
In principle
Reviewed-by: Jan Beulich <[email protected]>
but ...
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -19,14 +19,11 @@
#define __ASM_X86_HVM_VMX_VMX_H__
#include <xen/sched.h>
-#include <asm/types.h>
-#include <asm/regs.h>
+
#include <asm/asm_defns.h>
-#include <asm/processor.h>
-#include <asm/p2m.h>
-#include <asm/i387.h>
-#include <asm/hvm/trace.h>
#include <asm/hvm/vmx/vmcs.h>
+#include <asm/p2m.h>
+#include <asm/types.h>
... can this please become xen/types.h (and move up accordingly), so
things won't break here when my further work in that area lands?
Sure.
Jan
--
Xenia
