On 13.03.2023 18:51, Jason Andryuk wrote: > The header is unneeded - there are no uses of BUG() or WARN() in these > cpufreq files. Remove the include. It is still include transitively > from xen/lib.h. > > Signed-off-by: Jason Andryuk <[email protected]>
This, in a way, is a review comment on Oleksii's "xen: change <asm/bug.h> to <xen/bug.h>". We can certainly put in the change as you have it (for him to drop the touching of the two files), but I'd find it more logical to continue to be part of his change, just with the xen/bug.h replacement includes dropped. Thoughts, either of you? Things would be different if it was clear that the change here was dropping all unnecessary includes from the cpufreq files. But that doesn't look to be the case, as I think ... > --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c > +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c > @@ -35,7 +35,6 @@ > #include <xen/sched.h> > #include <xen/timer.h> > #include <xen/xmalloc.h> > -#include <asm/bug.h> > #include <asm/msr.h> > #include <asm/io.h> ... at least this one should be unnecessary as well, even more so ... > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -39,7 +39,6 @@ > #include <xen/guest_access.h> > #include <xen/domain.h> > #include <xen/cpu.h> > -#include <asm/bug.h> > #include <asm/io.h> ... here. Jan
