> On 15 Mar 2023, at 09:50, Christian Lindig <[email protected]> wrote: > > Acked-by: Christian Lindig <[email protected]>
Thank you, I might need to drop the ack in the next serie, because I need to rename arm_arch_capabilities.h to arm-arch-capabilities.h, unless for you is ok to retain it. > > >> On 15 Mar 2023, at 09:05, Luca Fancellu <[email protected]> wrote: >> >> type arch_physinfo_cap_flags = >> - | ARM of arm_physinfo_cap_flag list >> + | ARM of int >> | X86 of x86_physinfo_cap_flag list >> > > I notice that other capabilities are split into a list and not kept as a bit > field. Is this not needed here or am I misunderstanding the representation? Here I might need someone with ocaml knowledge, because on arm now arch_capabilities is not a bitfield, I have used “int” instead. My understanding is that to generate a list there needs to be bits set in the field (I might be wrong though). Maybe Andrew or Anthony can guide me better? I understand that Andrew is not really happy with this way to handle, but this is only until we have a proper framework for the capabilities. > > — C
