On 15.03.2023 18:01, Andrew Cooper wrote: > On 14/03/2023 4:30 pm, Jan Beulich wrote: >> On 12.03.2023 08:54, Huang Rui wrote: >>> From: Chen Jiqian <jiqian.c...@amd.com> >> An empty description won't do here. First of all you need to address the Why? >> As already hinted at in the reply to the earlier patch, it looks like you're >> breaking the intended IRQ model for PVH. > > I think this is rather unfair. > > Until you can point to the document which describes how IRQs are > intended to work in PVH, I'd say this series is pretty damn good attempt > to make something that functions, in the absence of any guidance.
Are you advocating for patches which don't explain why they make a certain change? Even in the absence of any documentation, the code itself can be taken as reference, and hence it can be pointed out that either something was wrong before, or something needs extending in a certain way to make some use case work which can't be mode work by other means. In the case of this series, without knowing the "Why?" for the various changes, it is also impossible to suggest alternative approaches. Jan
