Hi Ayan,
On 21/03/2023 14:03, Ayan Kumar Halder wrote:
The pabits, t0sz, root_order and sl0 values are the same as those for
ARM_64.
To me this read as the line should be common. But you still duplicate it.
In any case, you should justify this change with a pointer to the Arm
Arm. Not just saying they are common.
Signed-off-by: Ayan Kumar Halder <ayan.kumar.hal...@amd.com>
---
Changes from -
v1 - New patch.
v2 - 1. Added Ack.
v3 - 1. Dropped Ack.
2. Rebased the patch based on the previous change.
xen/arch/arm/p2m.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f34b6e6f11..20beecc6e8 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -2272,8 +2272,9 @@ void __init setup_virt_paging(void)
unsigned int sl0; /* Desired SL0, maximum in comment */
} pa_range_info[] __initconst = {
#ifdef CONFIG_ARM_32
- [0] = { 40, 24/*24*/, 1, 1 },
- [1] = { 0 } /* Invalid */
+ [0] = { 32, 32/*32*/, 0, 1 },
As I pointed out in one of the previous version, the root order is
different than ...
+ [1] = { 40, 24/*24*/, 1, 1 },
... here. Yet, you still keep P2M_ROOT_ORDER and P2M_ROOT_LEVEL
hardcoded. Your previous patch wants to define p2M_root_order and
p2m_root_level (lower-case intended). IOW making more code common
between arm64 and arm32.
Cheers,
--
Julien Grall
