On 04.04.2023 09:09, Andrew Cooper wrote: > On 04/04/2023 7:46 am, Jan Beulich wrote: >> PHYSDEVOP_pirq_eoi_gmfn_v<N> accepting just a single GFN implies that no >> more than 32k pIRQ-s can be used by a domain. Document this upper bound. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
Thanks, but because of the below I guess I'll make a v2. >> --- >> I was uncertain about also introducing a bounds check in code: We don't >> check for bogus / abusive values elsewhere either. > > Normally not, but in this case I suspect it's worth it. Without a > bounds check, don't we risk wandering off the page? Indeed we do; in debug builds we hit assertions. Jan
