On 03.05.2023 01:36, Vikram Garhwal wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -214,6 +214,7 @@ struct msi_msg; > #include <xen/device_tree.h> > > int iommu_assign_dt_device(struct domain *d, struct dt_device_node *dev); > +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev);
Hmm, exposing a function globally which, first and foremost because of requiring the caller to hold the correct lock(s), is pretty much internal, doesn't look very nice to me. Can this perhaps be put in a private header, such that it gets only limited visibility? Jan
