Hi, On 30/03/2023 09:50, Juergen Gross wrote:
Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success.
I usually find such change risky because it makes the backport more complex if we introduce a new call to hashtable_insert() and it is also quite difficult to review (the compiler would not help to confirm all the callers have changed).
So can you provide a compelling reason for doing the change? (consistency would not be one IMO)
Cheers, -- Julien Grall