On 12/05/2023 12:18 pm, Olaf Hering wrote: > Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper <andrew.coop...@citrix.com>: > >> Why is this 700, and the others just using regular perms? >> Also, doesn't it want quoting like the other examples too? > It is not clear why there is a single mkdir -m 0700 in the tree. > Most likely it will not give any extra security.
I agree. It's weird and doesn't have a good reason for being different. > The scripts source hotplug.sh, which defines a variable XEN_RUN_DIR. > I think it is better to use the shell variable instead of hardcoded paths. Sounds good. Does this allow for making any of these files no longer preprocessed by ./configure ? (i.e. cease being .in files) > Regarding quoting: there are many paths used without quoting. > For the beauty an additional (huge) change could be done to quote > everything. Not sure if it is worth the effort... Perhaps, but variables should always be quoted. At least make sure that new additions (and edits) leave things quoted. Thanks, ~Andrew
