On 5/12/23 03:05, Jan Beulich wrote: > On 11.05.2023 21:16, Stewart Hildebrand wrote: >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -219,7 +219,8 @@ int iommu_dt_domain_init(struct domain *d); >> int iommu_release_dt_devices(struct domain *d); >> >> /* >> - * Helper to add master device to the IOMMU using generic IOMMU DT bindings. >> + * Helpers to add master device to the IOMMU using generic (PCI-)IOMMU >> + * DT bindings. >> * >> * Return values: >> * 0 : device is protected by an IOMMU >> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); >> * (IOMMU is not enabled/present or device is not connected to it). >> */ >> int iommu_add_dt_device(struct dt_device_node *np); >> +#ifdef CONFIG_HAS_PCI >> +int iommu_add_dt_pci_device(struct pci_dev *pdev); >> +#endif > > Is the #ifdef really necessary?
No, I will remove in v3
