On Fri, May 26, 2023 at 8:29 AM Olaf Hering <[email protected]> wrote:

> The function always returns zero.
>

I think a better argument (which I propose to replace the content of the
commit message) would be something like this:

---
The program is structured so that fatal errors cause exit() to be called
directly, rather than being passed up the stack; returning a value here may
mislead people into believing otherwise.
---

With that change:

Reviewed-by: George Dunlap <[email protected]>

If that sounds OK to you I'll modify it on check-in.

 -George

Reply via email to