>>> On 07.05.18 at 23:07, <janakarajan.natara...@amd.com> wrote: > --- a/xen/include/asm-x86/hvm/vlapic.h > +++ b/xen/include/asm-x86/hvm/vlapic.h > @@ -137,6 +137,10 @@ void vlapic_ipi(struct vlapic *vlapic, uint32_t icr_low, > uint32_t icr_high); > > int vlapic_apicv_write(struct vcpu *v, unsigned int offset); > > +void vlapic_reg_write(struct vcpu *v, unsigned int offset, uint32_t val); > + > +uint32_t vlapic_reg_read(const struct vlapic *vlapic, unsigned int offset);
For them to be made non-static, they should really be counterparts of one another. This (to me) includes suitably matching parameter types (i.e. both should take struct vlapic * or struct vcpu *; the read one having it const is of course fine). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
