On 09/06/2023 10:31 am, Jan Beulich wrote: > On 08.06.2023 19:40, Andrew Cooper wrote: >> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together. > Right, that's one thing which should have been done right away. > The other is that both macros should have been purged from > tools/tests/x86_emulator/x86-emulate.h (which includes > xen-tools/common-macros.h). Luca?
Hmm - I explicitly checked that, and concluded they didn't... Happy to purge them if I'm wrong. ~Andrew